secmod: use lock + ht + .mli

This commit is contained in:
swrup 2025-12-06 23:25:29 +01:00
parent 846122b49c
commit 0d17d2a675
7 changed files with 141 additions and 71 deletions

View file

@ -1,19 +1,33 @@
(* TODO
- key rotation
- how many signkey to use?
we just use 1 for now *)
- key rotation
- how many signkey to use?
we just use 1 for now *)
open Syntax
type t = {
lock: Miou.Mutex.t;
sm_key: Signkey.t;
keys: Signkey.t list;
signkey_ht: (Crypto.EddsaPublicKey.t, Signkey.t) Hashtbl.t;
}
let get_sm_key t = t.sm_key
let get_signkeys t =
Miou.Mutex.protect t.lock @@ fun () ->
Hashtbl.to_seq_values t.signkey_ht |> List.of_seq
(* TODO *)
let update_signkeys _conn t signkeys =
Miou.Mutex.protect t.lock @@ fun () ->
List.iter
(fun signkey -> Hashtbl.replace t.signkey_ht signkey.Signkey.pub signkey)
signkeys
let dir = Fpath.(v "data" / "secmod_signkey")
let store_secmod_data t =
let _store_secmod_data t =
let* () = Data_file.write_eddsa Fpath.(dir / "sm_key") t.sm_key.priv in
t.keys
get_signkeys t
|> List.mapi (fun i key ->
let fname = Fpath.(dir / string_of_int i) in
(fname, key.Signkey.priv))
@ -24,7 +38,7 @@ let load conn =
Fmt.error_msg "secmod_signkey load error: invalid store state."
in
let* sm_key = Data_file.load_signkey conn Fpath.(dir / "sm_key") in
let* keys =
let* signkeys =
let l = List.init 1 (fun i -> Fpath.(dir / string_of_int i)) in
let* l =
Syntax.list_map (fun fname -> Data_file.load_signkey conn fname) l
@ -33,12 +47,40 @@ let load conn =
| Error () -> error_invalid_state
| Ok opt -> Ok opt
in
match (sm_key, keys) with
match (sm_key, signkeys) with
| None, None -> Ok None
| Some sm_key, Some keys -> Ok (Some { sm_key; keys })
| Some sm_key, Some signkeys ->
let lock = Miou.Mutex.create () in
let signkey_ht =
signkeys
|> List.map (fun v -> (v.Signkey.pub, v))
|> List.to_seq
|> Hashtbl.of_seq
in
Ok (Some { lock; sm_key; signkey_ht })
| _, _ -> error_invalid_state
let make_new () =
let lock = Miou.Mutex.create () in
let sm_key = Signkey.make () in
let keys = [ Signkey.make () ] in
{ sm_key; keys }
let signkeys = [ Signkey.make () ] in
let signkey_ht =
signkeys
|> List.map (fun v -> (v.Signkey.pub, v))
|> List.to_seq
|> Hashtbl.of_seq
in
{ lock; sm_key; signkey_ht }
let init conn =
match load conn with
| Ok None ->
let t = make_new () in
Logs.info (fun m -> m "secmod_signkey initialized with fresh keys");
t
| Ok (Some v) ->
Logs.info (fun m -> m "secmod_signkey initialized from storage");
v
| Error _ ->
(* TODO error: pretty print *)
Fmt.failwith "secmod_signkey init failure."