diff --git a/src/babillard.ml b/src/babillard.ml index 903925b..1a0b61f 100644 --- a/src/babillard.ml +++ b/src/babillard.ml @@ -449,9 +449,7 @@ let get_post id = in Ok reply -let thread_exists id = - match Db.find Q.get_is_thread id with Error _ -> false | Ok _ -> true +let thread_exists id = Result.is_ok (Db.find Q.get_is_thread id) (* true if post is an op too *) -let post_exists id = - match Db.find Q.get_is_post id with Error _ -> false | Ok _ -> true +let post_exists id = Result.is_ok (Db.find Q.get_is_post id) diff --git a/src/permap.ml b/src/permap.ml index d6bfc2a..762ffb0 100644 --- a/src/permap.ml +++ b/src/permap.ml @@ -111,7 +111,7 @@ let avatar_image request = Dream.respond ~headers:[ ("Content-Type", "image") ] avatar | Ok None | Error _ -> ( match Content.read "/assets/img/default_avatar.png" with - | None -> Dream.empty `Not_Found + | None -> failwith "can't find default avatar" | Some avatar -> Dream.respond ~headers:[ ("Content-Type", "image") ] avatar ) else Dream.respond ~status:`Not_Found "404: User does not exists" @@ -178,10 +178,12 @@ let thread_get request = let thread_id = Dream.param request "thread_id" in if Babillard.thread_exists thread_id then let thread_view = Pp_babillard.view_thread thread_id in - match thread_view with - | Error e -> render_unsafe e request - | Ok thread_view -> - render_unsafe (Thread_page.f thread_view thread_id request) request + let res = + match thread_view with + | Error e -> e + | Ok thread_view -> Thread_page.f thread_view thread_id request + in + render_unsafe res request else Dream.respond ~status:`Not_Found "404: Thread not found" (*form to reply to a thread *) @@ -246,9 +248,6 @@ let routes = [ get_ "/register" register_get; post "/register" register_post ] else [] -let not_found _ = - Dream.respond ~status:`Not_Found "404: This page does not exists!" - let () = let logger = if App.log then Dream.logger else Fun.id in Dream.run ~port:App.port @@ logger @@ Dream.cookie_sessions diff --git a/src/user.ml b/src/user.ml index 89835ec..f40b168 100644 --- a/src/user.ml +++ b/src/user.ml @@ -169,5 +169,4 @@ let upload_avatar files nick = Ok () | _files -> Error "More than one file provided" -let exists nick = - match Db.find_opt Q.get_user nick with Error _ -> false | Ok _ -> true +let exists nick = Result.is_ok (Db.find_opt Q.get_user nick)